Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove note about asset tarballs, the bug has been fixed in sensu-go #667

Merged
merged 2 commits into from
Aug 16, 2018

Conversation

nikkictl
Copy link

Signed-off-by: Nikki Attea nikki@sensu.io

Remove note about asset tarballs, the bug has been fixed in sensu-go

Description

Removes note stating that asset tarballs cannot be extracted.

Motivation and Context

Bug is fixed in sensu/sensu-go#1980 so the note is irrelevant.

How Has This Been Tested?

Locally, CI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New doc/guide
  • Fixing errata
  • Update (Add missing or refresh existing content)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • All tests have passed.

Signed-off-by: Nikki Attea <nikki@sensu.io>
@nikkictl nikkictl self-assigned this Aug 16, 2018
@nikkictl nikkictl requested a review from mercul3s August 16, 2018 15:23
@Blue0ctober Blue0ctober added in progress Currently being worked ready for review PR is ready to review and removed in progress Currently being worked labels Aug 16, 2018
Copy link
Contributor

@mercul3s mercul3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the spacing changes are causing an issue with the table formatting
screenshot from 2018-08-16 11-46-43

Signed-off-by: Nikki Attea <nikki@sensu.io>
@nikkictl
Copy link
Author

@mercul3s whoops I tested it locally and it appeared to format correctly.. I've reverted the spacing changes (dang, atom).. should be good to go now!

Copy link
Contributor

@mercul3s mercul3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good, thank you!

@nikkictl nikkictl merged commit a9b9dc5 into master Aug 16, 2018
@nikkictl nikkictl deleted the bugfix/asset-tarball branch August 16, 2018 21:11
@Blue0ctober Blue0ctober removed the ready for review PR is ready to review label Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants